oier/collective-lists
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(fase-18): CreateListModal replaces empty-create-then-rename flow

Browse Source 
`CreateListModal.svelte` is the new entry point for "New list" — opens
on the masthead button click, prefills the input with
`currentCollective.default_list_title` (Fase 18.3.1), shows an inline
autocomplete dropdown via `fetchTitleSuggestions`, and renders a
"Sugerencia: Compra #6" chip when (a) the typed value exactly matches a
catalog-curated prefix case-insensitively and (b) `computeNextNumber`
resolves a value (Fase 18.3.2). Submit is disabled while the trimmed
value is empty or creation is in flight (Fase 18.3.3). On submit, if the
catalog match still holds, the modal auto-suffixes "#N" before
inserting and the lists page shows a transient toast confirming the
final name (Fase 18.3.4).

The prefill effect is gated by a `wasOpen` edge-tracker — a naive
`$effect(() => { if (open) value = default })` re-runs whenever
`$currentCollective` updates (e.g. a realtime UPDATE landing after the
user typed something), which clobbered the typed value and froze the
submit button as disabled. The edge guard limits the prefill to the
false→true transition.

`/lists/+page.svelte`: the masthead "New list" button now opens the
modal instead of calling `createList(collective, '', user)` and goto-ing
to the detail page for inline rename. The legacy flow was nice for
quick creates but couldn't enforce a required title or surface the
catalog. Existing per-list actions are unchanged.

15 new i18n strings (en + es) for the modal, the suggestion chip, the
auto-numbered toast, and the manage-page subsection that ships in the
next commit.

Updated existing e2e specs: `lists.test.ts`'s `createList()` helper +
the C-13 guest path now drive the modal instead of the legacy
placeholder input; `session.test.ts` S-03 uses the modal for the
fresh-list setup. New `tests/e2e/list-title-flow.test.ts` adds LTF-01
(default prefill end-to-end with a Supabase-driven setDefaultListTitle
since the manage UI lands in the next commit) and LTF-03 (empty input
keeps submit disabled, even with whitespace).

Tests: 4 lists + 3 session + 2 new LTF specs all green (9/9).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Oier Bravo
2026-05-19 02:29:17 +02:00
parent 3c4551acd9
commit 4ce24a4145
7 changed files with 515 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
apps/web/messages/en.json
View File

@@ -342,5 +342,24 @@
"common_items_add_name_label": "Item name",
"common_items_add_name_placeholder": "e.g. olive oil",
"common_items_add_visibility_label": "Visibility",
"common_items_add_save": "Add"
"common_items_add_save": "Add",
"create_list_modal_title": "New shopping list",
"create_list_input_label": "List name",
"create_list_input_placeholder": "e.g. Weekly shop",
"create_list_submit": "Create",
"create_list_suggestion_chip": "Suggestion: {title}",
"create_list_auto_numbered_toast": "Created as “{title}”",
"manage_list_titles_section_title": "Suggested titles",
"manage_list_titles_blurb": "Pre-set a default title for new lists and curate suggestions admins want to surface.",
"manage_default_list_title_label": "Default new-list title",
"manage_default_list_title_placeholder": "e.g. Weekly shop",
"manage_default_list_title_clear": "Clear",
"manage_list_titles_empty": "No curated titles yet.",
"manage_list_titles_add_button": "Add title",
"manage_list_titles_add_modal_title": "Add suggested title",
"manage_list_titles_add_name_label": "Title",
"manage_list_titles_add_name_placeholder": "e.g. Compra",
"manage_list_titles_add_save": "Add",
"manage_list_titles_remove": "Remove",
"manage_list_titles_readonly": "Only admins can curate these titles."
}