feat(fase-10): CU-H08 dissolve collective — RPC + danger-zone UI
Migration 018 adds public.dissolve_collective(uuid): - admin-only; non-admin (member/guest/non-member) → errcode P0002 - single DELETE from public.collectives; all child tables cascade (collective_members, collective_invitations, shopping_lists → shopping_items, task_lists → tasks, notes, item_frequency, sync_conflicts — verified by audit, no schema change needed) /collective/manage gains a "Danger zone" card (admin-only) with a Dissolve button. The confirmation modal loads live counts of lists, tasks and notes, displays them in the warning, and requires the user to type the collective name exactly before the confirm button is enabled. On success, locals stores drop the collective and the user is sent to /lists (next collective) or /onboarding (none left). pgTAP 011 (8 assertions): RPC exists, member/guest/non-member all rejected with P0002, admin succeeds, collective row gone, child list cascade-deleted, members cascade-deleted. Playwright D-01..D-03 cover the happy path, the type-the-name guard, and member visibility. Auxiliary collective fixture (NOT the seed) per test — the seed collective must survive every run for downstream suites. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
@@ -1,5 +1,6 @@
|
||||
<script lang="ts">
|
||||
import { onMount } from 'svelte';
|
||||
import { goto } from '$app/navigation';
|
||||
import { getSupabase } from '$lib/supabase';
|
||||
import { currentUser } from '$lib/stores/auth';
|
||||
import { currentCollective, collectiveMembers, userCollectives } from '$lib/stores/collective';
|
||||
@@ -212,6 +213,92 @@
|
||||
currentCollective.set(c);
|
||||
userCollectives.update((list) => list.map((it) => (it.id === c.id ? c : it)));
|
||||
}
|
||||
|
||||
// ── Fase 10.3: dissolve collective (CU-H08) ─────────────────────────────
|
||||
let dissolveOpen = $state(false);
|
||||
let dissolveConfirmInput = $state('');
|
||||
let dissolveError = $state<string | null>(null);
|
||||
let dissolveInFlight = $state(false);
|
||||
let listsCount = $state(0);
|
||||
let tasksCount = $state(0);
|
||||
let notesCount = $state(0);
|
||||
|
||||
const dissolveConfirmReady = $derived(
|
||||
!!$currentCollective && dissolveConfirmInput === $currentCollective.name
|
||||
);
|
||||
|
||||
async function openDissolve() {
|
||||
if (!$currentCollective || !isAdmin) return;
|
||||
dissolveOpen = true;
|
||||
dissolveConfirmInput = '';
|
||||
dissolveError = null;
|
||||
// Best-effort counts; failures fall back to 0.
|
||||
const supabase = getSupabase();
|
||||
const [l, t, n] = await Promise.all([
|
||||
supabase
|
||||
.from('shopping_lists')
|
||||
.select('id', { head: true, count: 'exact' })
|
||||
.eq('collective_id', $currentCollective.id),
|
||||
supabase
|
||||
.from('tasks')
|
||||
.select('id', { head: true, count: 'exact' })
|
||||
.in(
|
||||
'list_id',
|
||||
(
|
||||
await supabase
|
||||
.from('task_lists')
|
||||
.select('id')
|
||||
.eq('collective_id', $currentCollective.id)
|
||||
).data?.map((r) => r.id) ?? []
|
||||
),
|
||||
supabase
|
||||
.from('notes')
|
||||
.select('id', { head: true, count: 'exact' })
|
||||
.eq('collective_id', $currentCollective.id)
|
||||
]);
|
||||
listsCount = l.count ?? 0;
|
||||
tasksCount = t.count ?? 0;
|
||||
notesCount = n.count ?? 0;
|
||||
}
|
||||
|
||||
function closeDissolve() {
|
||||
dissolveOpen = false;
|
||||
dissolveConfirmInput = '';
|
||||
dissolveError = null;
|
||||
}
|
||||
|
||||
async function confirmDissolve() {
|
||||
if (!$currentCollective || !dissolveConfirmReady || dissolveInFlight) return;
|
||||
const target = $currentCollective;
|
||||
dissolveInFlight = true;
|
||||
dissolveError = null;
|
||||
|
||||
const { error: rpcErr } = await getSupabase().rpc('dissolve_collective', {
|
||||
p_collective_id: target.id
|
||||
});
|
||||
if (rpcErr) {
|
||||
dissolveInFlight = false;
|
||||
dissolveError = rpcErr.message;
|
||||
return;
|
||||
}
|
||||
|
||||
// Update local stores. Pick the next collective or redirect to onboarding.
|
||||
const remaining = $userCollectives.filter((c) => c.id !== target.id);
|
||||
userCollectives.set(remaining);
|
||||
dissolveOpen = false;
|
||||
dissolveInFlight = false;
|
||||
|
||||
if (remaining.length > 0) {
|
||||
const next = remaining[0];
|
||||
currentCollective.set(next);
|
||||
localStorage.setItem('activeCollectiveId', next.id);
|
||||
await goto('/lists');
|
||||
} else {
|
||||
currentCollective.set(null);
|
||||
localStorage.removeItem('activeCollectiveId');
|
||||
await goto('/onboarding');
|
||||
}
|
||||
}
|
||||
</script>
|
||||
|
||||
<div class="flex flex-1 flex-col overflow-hidden">
|
||||
@@ -401,7 +488,69 @@
|
||||
<p class="mt-1 text-xs text-text-secondary">{m.manage_link_expires()}</p>
|
||||
{/if}
|
||||
</section>
|
||||
|
||||
<!-- Danger zone (Fase 10.3) — admin only -->
|
||||
<section class="mt-10 rounded-lg border border-destructive/40 p-4">
|
||||
<h2 class="mb-2 text-[13px] font-semibold uppercase tracking-[0.05em] text-destructive">
|
||||
{m.manage_dissolve_section()}
|
||||
</h2>
|
||||
<p class="mb-3 text-sm text-text-secondary">{m.manage_dissolve_blurb()}</p>
|
||||
<button
|
||||
type="button"
|
||||
data-testid="dissolve-collective-button"
|
||||
onclick={() => void openDissolve()}
|
||||
class="rounded-md border border-destructive px-4 py-2 text-sm font-semibold text-destructive
|
||||
hover:bg-destructive/10"
|
||||
>
|
||||
{m.manage_dissolve_button()}
|
||||
</button>
|
||||
</section>
|
||||
{/if}
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{#if dissolveOpen && $currentCollective}
|
||||
<div class="fixed inset-0 z-50 flex items-center justify-center bg-black/40 p-4" data-testid="dissolve-modal">
|
||||
<div class="w-full max-w-md rounded-lg bg-surface p-5 shadow-[0px_20px_40px_rgba(15,23,42,0.2)] dark:bg-surface-raised">
|
||||
<h2 class="mb-2 text-base font-semibold text-slate-900 dark:text-slate-50">
|
||||
{m.manage_dissolve_title({ name: $currentCollective.name })}
|
||||
</h2>
|
||||
<p class="mb-4 text-sm text-text-secondary">
|
||||
{m.manage_dissolve_warning({ lists: listsCount, tasks: tasksCount, notes: notesCount })}
|
||||
</p>
|
||||
<label for="dissolve-confirm-input" class="mb-1 block text-xs font-medium text-text-secondary">
|
||||
{m.manage_dissolve_confirm_label({ name: $currentCollective.name })}
|
||||
</label>
|
||||
<input
|
||||
id="dissolve-confirm-input"
|
||||
data-testid="dissolve-confirm-input"
|
||||
type="text"
|
||||
bind:value={dissolveConfirmInput}
|
||||
class="mb-3 w-full rounded-lg border border-slate-300 bg-surface px-3 py-2 text-sm
|
||||
focus:border-slate-500 focus:outline-none dark:border-slate-600 dark:bg-slate-800"
|
||||
/>
|
||||
{#if dissolveError}
|
||||
<p class="mb-3 text-sm text-destructive" data-testid="dissolve-error">{dissolveError}</p>
|
||||
{/if}
|
||||
<div class="flex justify-end gap-2">
|
||||
<button
|
||||
type="button"
|
||||
onclick={closeDissolve}
|
||||
class="rounded-md px-3 py-1.5 text-sm font-medium text-slate-600 hover:bg-slate-100 dark:text-slate-300 dark:hover:bg-slate-800"
|
||||
>
|
||||
{m.common_cancel()}
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
data-testid="dissolve-confirm-button"
|
||||
disabled={!dissolveConfirmReady || dissolveInFlight}
|
||||
onclick={() => void confirmDissolve()}
|
||||
class="rounded-md bg-destructive px-4 py-1.5 text-sm font-semibold text-white hover:opacity-90 disabled:opacity-50"
|
||||
>
|
||||
{m.manage_dissolve_confirm_button()}
|
||||
</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
{/if}
|
||||
|
||||
103
apps/web/tests/e2e/dissolve-collective.test.ts
Normal file
103
apps/web/tests/e2e/dissolve-collective.test.ts
Normal file
@@ -0,0 +1,103 @@
|
||||
/**
|
||||
* D-series: /collective/manage → dissolve (Fase 10.3, CU-H08).
|
||||
*
|
||||
* ⚠️ This suite must NOT dissolve the seed collective. We create an auxiliary
|
||||
* collective per test, manipulate it, then either let the test dissolve it
|
||||
* (D-01) or clean it up in afterEach.
|
||||
*/
|
||||
import { test, expect } from '@playwright/test';
|
||||
import { USERS } from '../fixtures/users.js';
|
||||
import { loginAs } from '../fixtures/login.js';
|
||||
import { closePool, sql } from '@colectivo/test-utils';
|
||||
|
||||
test.describe.configure({ mode: 'serial' });
|
||||
|
||||
const aux: { id: string | null } = { id: null };
|
||||
const auxName = `Aux dissolve ${Date.now()}`;
|
||||
|
||||
/**
|
||||
* Create an auxiliary collective owned (created_by) by Borja but with Ana
|
||||
* as the sole admin (Borja is dropped from membership). This lets Ana
|
||||
* dissolve it from the UI without touching the seed.
|
||||
*/
|
||||
async function createAuxCollective(): Promise<string> {
|
||||
const r = await sql(
|
||||
`INSERT INTO public.collectives (name, emoji, created_by)
|
||||
VALUES ($1, '💥', $2) RETURNING id`,
|
||||
[auxName, USERS.borja.id]
|
||||
);
|
||||
const id = r.rows[0].id as string;
|
||||
await sql(
|
||||
`INSERT INTO public.collective_members (collective_id, user_id, role)
|
||||
VALUES ($1, $2, 'admin'), ($1, $3, 'member')`,
|
||||
[id, USERS.ana.id, USERS.borja.id]
|
||||
);
|
||||
return id;
|
||||
}
|
||||
|
||||
test.describe('Dissolve collective (CU-H08)', () => {
|
||||
test.afterEach(async () => {
|
||||
if (aux.id) {
|
||||
// Best-effort cleanup if the test didn't dissolve it.
|
||||
await sql('DELETE FROM public.collectives WHERE id = $1', [aux.id]);
|
||||
aux.id = null;
|
||||
}
|
||||
});
|
||||
|
||||
test.afterAll(async () => {
|
||||
await closePool();
|
||||
});
|
||||
|
||||
test('D-03: Borja (member) does NOT see the dissolve button', async ({ page }) => {
|
||||
aux.id = await createAuxCollective();
|
||||
await loginAs(page, USERS.borja);
|
||||
// Switch active collective to the aux one in localStorage, then reload.
|
||||
await page.evaluate((id) => localStorage.setItem('activeCollectiveId', id), aux.id);
|
||||
await page.goto('/collective/manage');
|
||||
// Make sure the page is hydrated by waiting on a known member row.
|
||||
await expect(page.getByTestId(`member-row-${USERS.ana.id}`)).toBeVisible({ timeout: 15_000 });
|
||||
// Borja must not see the dissolve button (admin-gated).
|
||||
await expect(page.getByTestId('dissolve-collective-button')).toHaveCount(0);
|
||||
});
|
||||
|
||||
test('D-02: dissolve button disabled until input matches collective name exactly', async ({
|
||||
page
|
||||
}) => {
|
||||
aux.id = await createAuxCollective();
|
||||
await loginAs(page, USERS.ana);
|
||||
await page.evaluate((id) => localStorage.setItem('activeCollectiveId', id), aux.id);
|
||||
await page.goto('/collective/manage');
|
||||
await page.getByTestId('dissolve-collective-button').click();
|
||||
|
||||
const confirm = page.getByTestId('dissolve-confirm-button');
|
||||
await expect(confirm).toBeDisabled();
|
||||
|
||||
await page.getByTestId('dissolve-confirm-input').fill('wrong name');
|
||||
await expect(confirm).toBeDisabled();
|
||||
|
||||
await page.getByTestId('dissolve-confirm-input').fill(auxName);
|
||||
await expect(confirm).toBeEnabled();
|
||||
});
|
||||
|
||||
test('D-01: Ana dissolves auxiliary collective → redirect + row gone', async ({ page }) => {
|
||||
aux.id = await createAuxCollective();
|
||||
await loginAs(page, USERS.ana);
|
||||
await page.evaluate((id) => localStorage.setItem('activeCollectiveId', id), aux.id);
|
||||
await page.goto('/collective/manage');
|
||||
await page.getByTestId('dissolve-collective-button').click();
|
||||
|
||||
await page.getByTestId('dissolve-confirm-input').fill(auxName);
|
||||
await page.getByTestId('dissolve-confirm-button').click();
|
||||
|
||||
// After dissolve we either land on /lists (other collectives remain) or
|
||||
// /onboarding (no collectives). Ana still has the seed one, so /lists.
|
||||
await expect(page).toHaveURL(/\/(lists|onboarding)$/, { timeout: 15_000 });
|
||||
|
||||
const r = await sql('SELECT count(*)::int AS n FROM public.collectives WHERE id = $1', [
|
||||
aux.id
|
||||
]);
|
||||
expect(r.rows[0].n).toBe(0);
|
||||
// Test cleanup already happened via cascade.
|
||||
aux.id = null;
|
||||
});
|
||||
});
|
||||
Reference in New Issue
Block a user