Files
collective-lists/apps/web/tests/e2e/items.test.ts
Oier Bravo Urtasun 1cb408acc2 feat(fase-5.10): /lists/[id] row redesign — buttons + swipe-toggle + overlay
Replaces the checkbox/hover-delete model with an explicit gesture+overlay
flow on /lists/[id].

Row anatomy (new)
  [drag-handle]  [name as button]  [qty stepper  − N +]
  - No checkbox in normal mode.
  - Checked items render with strikethrough + muted text.
  - Drag handle always visible on mobile; revealed on hover on desktop
    (md:opacity-0 md:group-hover:opacity-100). The handle owns the drag
    (pointerdown → dragEnabled=true), so row swipes + taps keep working.

Swipe gestures (symmetric toggle, no delete)
  unchecked + swipe RIGHT → mark checked (green success reveal)
  checked   + swipe LEFT  → mark unchecked (neutral reveal)
  opposite direction for each state is a no-op (snaps back).
  SWIPE_COMMIT_THRESHOLD=120 (was 200 for delete); REVEAL_WIDTH=96.
  Symmetry means undo is the inverse swipe — no undoQueue on toggles.

Double-tap overlay (name + delete + confirm)
  Short tap: no-op. Two taps within DOUBLE_TAP_WINDOW_MS (300 ms) open a
  full-screen dialog (bottom sheet on mobile) with:
    - X close button (top-right)
    - name input
    - Delete button (red) → scheduleUndoable → UndoToast
    - Confirm button (primary) → updateItem({ name })
  Click outside / Escape / X all dismiss without saving.

Tests
  items.test.ts
    D-03 rewritten: double-tap opens overlay, value matches, X closes.
    D-04 rewritten: overlay Delete removes the row; toast locator scoped
      out of itemRow so it doesn't shadow the assertion.
  realtime.test.ts
    R-E-02 updated: Ana renames via overlay → Borja sees new name over
      Realtime UPDATE. (The check/uncheck path is now gestural only and
      chromium touch emulation is too flaky to drive it in E2E; Vitest
      integration R-02 still covers the UPDATE-row-payload invariant.)
  mobile-swipe-delete.test.ts stays describe.skip — will be renamed and
  rewritten for the new semantics once WebKit install lands in CI.

i18n
  list_qty_decrease, list_qty_increase, list_reorder_handle,
  list_edit_item, list_confirm, list_close — en/es.

Verification
  just test-e2e → 40 passed, 2 skipped (same as pre-change).
  Type-check clean.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-13 19:20:55 +02:00

146 lines
5.9 KiB
TypeScript

/**
* D-series (UI): Shopping item CRUD flows on `/lists/[id]`.
*
* Each test does a full Keycloak login. The seed list ("Weekly shop",
* id bbbb...) is created by supabase/seed.sql and reused read-only by all
* assertions that don't mutate it. Tests that do mutate (add / check / delete)
* use items whose names include the Date.now() stamp so they're unique.
*/
import { test, expect, type Page } from '@playwright/test';
import { USERS } from '../fixtures/users.js';
import { loginAs } from '../fixtures/login.js';
const SEED_LIST_ID = 'bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb';
const SEED_LIST_PATH = `/lists/${SEED_LIST_ID}`;
const ADD_ITEM_PLACEHOLDER = /add item|añadir producto/i;
async function gotoSeedList(page: Page) {
await page.goto(SEED_LIST_PATH);
// Sidebar collective loaded = we're authenticated and the page has hydrated.
await expect(page.getByRole('button', { name: /Casa García-López/ })).toBeVisible({
timeout: 15_000
});
}
/** Find the row for a given item. The template sets role="listitem" per row. */
function itemRow(page: Page, name: string) {
return page.locator('[role="listitem"]').filter({ hasText: name }).first();
}
test.describe('Shopping items — member (Borja)', () => {
test.beforeEach(async ({ page }) => {
await loginAs(page, USERS.borja);
});
test('D-01: can open the seed list and see its items', async ({ page }) => {
await gotoSeedList(page);
// Seed items: Milk, Bread, Eggs, Coffee, Apples. Scope to listitem rows
// so we don't collide with the suggestion chips that share the same text.
await expect(itemRow(page, 'Milk')).toBeVisible({ timeout: 10_000 });
await expect(itemRow(page, 'Bread')).toBeVisible();
await expect(itemRow(page, 'Coffee')).toBeVisible();
});
test('D-02: can add a new item via the sticky form', async ({ page }) => {
await gotoSeedList(page);
const nameInput = page.getByPlaceholder(ADD_ITEM_PLACEHOLDER);
await expect(nameInput).toBeVisible({ timeout: 10_000 });
const itemName = `E2E-item-${Date.now()}`;
await nameInput.fill(itemName);
await nameInput.press('Enter');
await expect(page.getByText(itemName)).toBeVisible({ timeout: 5_000 });
// Reload to confirm the item persisted (not just optimistic).
await page.reload();
await expect(page.getByText(itemName)).toBeVisible({ timeout: 10_000 });
});
test('D-03: double-tapping a row opens the edit overlay (new interaction)', async ({ page }) => {
await gotoSeedList(page);
const nameInput = page.getByPlaceholder(ADD_ITEM_PLACEHOLDER);
await expect(nameInput).toBeVisible({ timeout: 10_000 });
const itemName = `Check-me-${Date.now()}`;
await nameInput.fill(itemName);
await nameInput.press('Enter');
const row = itemRow(page, itemName);
await expect(row).toBeVisible({ timeout: 5_000 });
// Double-tap opens the overlay — the new edit path.
await row.getByRole('button', { name: itemName }).dblclick();
const overlay = page.getByTestId('edit-overlay');
await expect(overlay).toBeVisible({ timeout: 3_000 });
await expect(overlay.getByPlaceholder(/add item|añadir producto/i)).toHaveValue(itemName);
// Close the overlay without saving — X button.
await overlay.getByRole('button', { name: /close|cerrar/i }).click();
await expect(overlay).not.toBeVisible({ timeout: 3_000 });
});
test('D-04: overlay Delete button removes the row with an undo toast', async ({ page }) => {
await gotoSeedList(page);
const nameInput = page.getByPlaceholder(ADD_ITEM_PLACEHOLDER);
await expect(nameInput).toBeVisible({ timeout: 10_000 });
const itemName = `Delete-me-${Date.now()}`;
await nameInput.fill(itemName);
await nameInput.press('Enter');
const row = itemRow(page, itemName);
await expect(row).toBeVisible({ timeout: 5_000 });
// Double-tap → overlay → Delete. (The swipe gesture is a toggle now,
// not a delete; delete lives behind the overlay.)
await row.getByRole('button', { name: itemName }).dblclick();
const overlay = page.getByTestId('edit-overlay');
await expect(overlay).toBeVisible({ timeout: 3_000 });
await overlay.getByRole('button', { name: /^delete$|^eliminar$/i }).click();
// Row gone from the list; toast scoped out via itemRow locator.
await expect(itemRow(page, itemName)).not.toBeVisible({ timeout: 5_000 });
});
test('D-06: frequency suggestions render below the add-item input', async ({ page }) => {
await gotoSeedList(page);
const nameInput = page.getByPlaceholder(ADD_ITEM_PLACEHOLDER);
await expect(nameInput).toBeVisible({ timeout: 10_000 });
// Focus the input. The seed data has "milk", "bread", "eggs", etc. in
// item_frequency, so suggestion chips should render.
await nameInput.click();
// At least one of the seed-frequency items should be visible as a chip.
await expect(page.getByRole('button', { name: /^milk$/i })).toBeVisible({ timeout: 5_000 });
// Typing a prefix should narrow suggestions. "mi" matches "milk".
await nameInput.fill('mi');
await expect(page.getByRole('button', { name: /^milk$/i })).toBeVisible({ timeout: 3_000 });
});
});
test.describe('Shopping items — guest (David, read-only)', () => {
test.beforeEach(async ({ page }) => {
await loginAs(page, USERS.david);
});
test('D-10: David sees seed items but cannot commit a new one', async ({ page }) => {
await gotoSeedList(page);
await expect(itemRow(page, 'Milk')).toBeVisible({ timeout: 15_000 });
// Either the add input is hidden for guests, or typing + Enter does not
// commit a persisted item (RLS blocks the insert → the optimistic row,
// if any, rolls back).
const input = page.getByPlaceholder(ADD_ITEM_PLACEHOLDER);
const visible = await input.isVisible({ timeout: 2_000 }).catch(() => false);
if (visible) {
const name = `Guest-sneaky-${Date.now()}`;
await input.fill(name);
await input.press('Enter');
await page.waitForTimeout(1_500);
await page.reload();
// After reload, nothing persisted on the server should render.
await expect(page.getByText(name)).not.toBeVisible({ timeout: 5_000 });
}
});
});