Fase 16.2 + 16.3 — replace the bare `m.loading()` text at every
pre-existing async-loading site with `<Spinner size=...> + <span>`.
Text is kept (visual fallback + tooltip / SR redundancy). No new
loading semantics — only existing flags get a visual indicator.
Sites:
- (app)/+layout.svelte: auth splash gets `size="lg"` centred under the
loading label.
- (app)/search/+page.svelte: inline `size="sm"` next to the search-in-flight
copy.
- (app)/notes/archive/+page.svelte: inline `size="sm"` next to the
archive-load copy.
- lib/components/CreateCollectiveModal.svelte: inline `size="sm"` inside
the disabled Save button while the create RPC is in flight.
- (app)/collective/manage/+page.svelte: three sites — members-list load,
invitation-generate button, and add-common-item Save button.
E2E (tests/e2e/spinner.test.ts):
- SP-E-01 throttles search_in_collective RPC by 500ms and asserts the
spinner is visible in the loading paragraph.
- SP-E-02 throttles set_item_frequency_weight RPC and asserts the spinner
is scoped inside the Save button.
- SP-E-03 seeds an expired `sb-192-auth-token` so GoTrue is forced to
call /auth/v1/token, then hangs that endpoint indefinitely and
asserts the splash spinner is visible. Storage key derivation matches
Supabase's `sb-${hostname.split('.')[0]}-auth-token` default; we
populate both the LAN-IP variant and a loopback fallback for
resilience.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
121 lines
3.9 KiB
Svelte
121 lines
3.9 KiB
Svelte
<script lang="ts">
|
|
import { goto } from '$app/navigation';
|
|
import { getSupabase } from '$lib/supabase';
|
|
import { currentCollective, userCollectives } from '$lib/stores/collective';
|
|
import Spinner from './Spinner.svelte';
|
|
import * as m from '$lib/paraglide/messages';
|
|
|
|
let { onClose }: { onClose: () => void } = $props();
|
|
|
|
const EMOJI_OPTIONS = [
|
|
'🏠', '🏡', '🏢', '🏣', '🏤', '🏥', '🏦', '🏨',
|
|
'🏩', '🏪', '🏫', '🏬', '🏭', '🏯', '🏰', '🗼',
|
|
'🌆', '🌇', '🌃', '🌉', '🏙️', '⛺', '🌴', '🌵'
|
|
];
|
|
|
|
let name = $state('');
|
|
let emoji = $state('🏠');
|
|
let creating = $state(false);
|
|
let error = $state<string | null>(null);
|
|
|
|
async function submit() {
|
|
if (!name.trim() || creating) return;
|
|
creating = true;
|
|
error = null;
|
|
const { data, error: rpcErr } = await getSupabase().rpc('create_collective', {
|
|
p_name: name.trim(),
|
|
p_emoji: emoji
|
|
});
|
|
if (rpcErr || !data) {
|
|
creating = false;
|
|
error = rpcErr?.message ?? 'Failed to create collective.';
|
|
return;
|
|
}
|
|
const created = {
|
|
...(data as { id: string; name: string; emoji: string; created_at: string }),
|
|
// New collective starts with no flags — every section ON by default.
|
|
feature_flags: {} as import('@colectivo/types').FeatureFlags
|
|
};
|
|
userCollectives.update((list) => [...list, created]);
|
|
currentCollective.set(created);
|
|
localStorage.setItem('activeCollectiveId', created.id);
|
|
creating = false;
|
|
onClose();
|
|
await goto('/lists');
|
|
}
|
|
</script>
|
|
|
|
<div class="fixed inset-0 z-50 flex items-center justify-center bg-black/40 p-4" data-testid="create-collective-modal">
|
|
<div class="w-full max-w-md rounded-lg bg-surface p-5 shadow-[0px_20px_40px_rgba(15,23,42,0.2)] dark:bg-surface-raised">
|
|
<h2 class="mb-4 text-base font-semibold text-slate-900 dark:text-slate-50">
|
|
{m.create_collective_modal_title()}
|
|
</h2>
|
|
<form onsubmit={(e) => { e.preventDefault(); void submit(); }} class="space-y-4">
|
|
<div>
|
|
<label for="cc-modal-name" class="mb-1 block text-sm font-medium text-slate-700 dark:text-slate-300">
|
|
{m.onboarding_collective_name()}
|
|
</label>
|
|
<input
|
|
id="cc-modal-name"
|
|
data-testid="create-collective-modal-name"
|
|
type="text"
|
|
bind:value={name}
|
|
placeholder={m.onboarding_collective_name_placeholder()}
|
|
maxlength="60"
|
|
class="w-full rounded-lg border border-slate-300 bg-surface px-3 py-2 text-sm
|
|
focus:border-slate-500 focus:outline-none dark:border-slate-600 dark:bg-slate-800"
|
|
/>
|
|
</div>
|
|
|
|
<div>
|
|
<p class="mb-2 text-sm font-medium text-slate-700 dark:text-slate-300">
|
|
{m.onboarding_collective_emoji()}
|
|
</p>
|
|
<div class="grid grid-cols-8 gap-1">
|
|
{#each EMOJI_OPTIONS as e}
|
|
<button
|
|
type="button"
|
|
class="flex h-9 w-9 items-center justify-center rounded-md text-xl transition-colors
|
|
{emoji === e
|
|
? 'bg-slate-900 dark:bg-slate-100'
|
|
: 'hover:bg-slate-100 dark:hover:bg-slate-700'}"
|
|
onclick={() => (emoji = e)}
|
|
aria-label={e}
|
|
>{e}</button>
|
|
{/each}
|
|
</div>
|
|
</div>
|
|
|
|
{#if error}
|
|
<p class="text-sm text-red-600">{error}</p>
|
|
{/if}
|
|
|
|
<div class="flex justify-end gap-2">
|
|
<button
|
|
type="button"
|
|
onclick={onClose}
|
|
class="rounded-md px-3 py-1.5 text-sm font-medium text-slate-600 hover:bg-slate-100
|
|
dark:text-slate-300 dark:hover:bg-slate-800"
|
|
>
|
|
{m.common_cancel()}
|
|
</button>
|
|
<button
|
|
type="submit"
|
|
data-testid="create-collective-modal-submit"
|
|
disabled={!name.trim() || creating}
|
|
class="inline-flex items-center gap-2 rounded-lg bg-slate-900 px-4 py-1.5 text-sm font-semibold text-white
|
|
transition-opacity hover:opacity-90 disabled:opacity-50
|
|
dark:bg-slate-50 dark:text-slate-900"
|
|
>
|
|
{#if creating}
|
|
<Spinner size="sm" />
|
|
<span>{m.loading()}</span>
|
|
{:else}
|
|
{m.create_collective_modal_button()}
|
|
{/if}
|
|
</button>
|
|
</div>
|
|
</form>
|
|
</div>
|
|
</div>
|