From 2c5c4004ddd98f80e0f1e63ebd1c349504ef4f19 Mon Sep 17 00:00:00 2001 From: StraToN Date: Mon, 2 May 2022 20:51:19 +0000 Subject: [PATCH] chore: storing version and changelog --- CHANGELOG.md | 9 +++++++++ .../game/core-scripts/esc/commands/custom.gd | 2 +- .../game/core-scripts/esc/esc_event_manager.gd | 4 ++-- .../esc/types/esc_command_argument_descriptor.gd | 2 +- 4 files changed, 13 insertions(+), 4 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index c2b891be..49652ca2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,12 @@ +## [4.0.0-alpha.181](https://github.com/godot-escoria/escoria-demo-game/compare/v0.0.0...v4.0.0-alpha.181) (2022-05-02) + + +### Bug Fixes + +* implement varargs for ESC commands. 'custom' makes use of this [#592](https://github.com/godot-escoria/escoria-demo-game/issues/592) ([738ce0d](https://github.com/godot-escoria/escoria-demo-game/commit/738ce0debca0f51ae3b639838eb959c01850ce9c)) + + + ## [4.0.0-alpha.180](https://github.com/godot-escoria/escoria-demo-game/compare/v0.0.0...v4.0.0-alpha.180) (2022-05-02) diff --git a/addons/escoria-core/game/core-scripts/esc/commands/custom.gd b/addons/escoria-core/game/core-scripts/esc/commands/custom.gd index 5ba387cf..2e9bea32 100644 --- a/addons/escoria-core/game/core-scripts/esc/commands/custom.gd +++ b/addons/escoria-core/game/core-scripts/esc/commands/custom.gd @@ -9,7 +9,7 @@ # - *object*: Global ID of the target `ESCItem` # - *node*: Name of the child node of the target `ESCItem` # - *func_name*: Name of the function to be called -# - params: Any arguments to be passed to the function (array and object parameters are not supported). +# - params: Any arguments to be passed to the function (array and object parameters are not supported). # Multiple parameters can be passed by simply passing them in as additional arguments separated by # spaces, e.g. `custom the_object the_node the_function arg1 arg2 arg3` # diff --git a/addons/escoria-core/game/core-scripts/esc/esc_event_manager.gd b/addons/escoria-core/game/core-scripts/esc/esc_event_manager.gd index d561c8ff..a05fed91 100644 --- a/addons/escoria-core/game/core-scripts/esc/esc_event_manager.gd +++ b/addons/escoria-core/game/core-scripts/esc/esc_event_manager.gd @@ -205,7 +205,7 @@ func queue_event(event: ESCEvent) -> void: escoria.logger.debug(message % [event.name, CHANNEL_FRONT]) return elif _is_event_running(event, CHANNEL_FRONT): - # Don't queue the same event if it's already running. + # Don't queue the same event if it's already running. escoria.logger.debug( "Event %s already running in channel '%s'. Won't be queued." % [event.name, CHANNEL_FRONT] @@ -248,7 +248,7 @@ func queue_background_event(channel_name: String, event: ESCEvent) -> void: escoria.logger.debug(message % [event.name, channel_name]) return elif _is_event_running(event, CHANNEL_FRONT): - # Don't queue the same event if it's already running. + # Don't queue the same event if it's already running. escoria.logger.debug( "Event %s already running in channel '%s'. Won't be queued." % [event.name, channel_name] diff --git a/addons/escoria-core/game/core-scripts/esc/types/esc_command_argument_descriptor.gd b/addons/escoria-core/game/core-scripts/esc/types/esc_command_argument_descriptor.gd index 6d40f187..8d9b09d8 100644 --- a/addons/escoria-core/game/core-scripts/esc/types/esc_command_argument_descriptor.gd +++ b/addons/escoria-core/game/core-scripts/esc/types/esc_command_argument_descriptor.gd @@ -120,7 +120,7 @@ func validate(command: String, arguments: Array) -> bool: if arguments[index] == null: # No type checking for null values continue - + if has_varargs and index == arguments.size() - 1: # If we have varargs at the end, do not validate them. continue