oier/gymkhana-actions
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix "global_changed" signal arguments order (#482)

Browse Source
This commit is contained in:
Julian Murgia
2021-12-15 08:49:36 +01:00
committed by GitHub
parent 62993dcd7d
commit 3e4d936007
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
addons/escoria-core/game/core-scripts/esc/esc_globals_manager.gd
View File

@@ -41,11 +41,12 @@ func register_reserved_global(key: String, value = null) -> void:
"Global key %s is already registered as reserved" % key "Global key %s is already registered as reserved" % key
] ]
) )
var old_value = _globals[key]
_reserved_globals[key] = value _reserved_globals[key] = value
_globals[key] = value _globals[key] = value
if value != null: if value != null:
emit_signal("global_changed", key, _globals[key], value) emit_signal("global_changed", key, old_value, _globals[key])
# Get the current value of a global # Get the current value of a global
@@ -91,8 +92,9 @@ func set_global(key: String, value, ignore_reserved: bool = false) -> void:
"Global key %s is reserved and can not be overridden" % key "Global key %s is reserved and can not be overridden" % key
] ]
) )
_globals[key] = value
emit_signal("global_changed", key, _globals[key], value) emit_signal("global_changed", key, _globals[key], value)
_globals[key] = value
# Set all globals that match the pattern to the value # Set all globals that match the pattern to the value