oier/gymkhana-actions
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix initial value of globals in signals emissions (#483)

Browse Source
This commit is contained in:
Julian Murgia
2021-12-31 16:57:10 +01:00
committed by GitHub
parent f5f11e0942
commit ba0b66656d
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
addons/escoria-core/game/core-scripts/esc/esc_globals_manager.gd
View File

@@ -41,7 +41,7 @@ func register_reserved_global(key: String, value = null) -> void:
"Global key %s is already registered as reserved" % key "Global key %s is already registered as reserved" % key
] ]
) )
var old_value = _globals[key] var old_value = _globals[key] if _globals.has(key) else ""
_reserved_globals[key] = value _reserved_globals[key] = value
_globals[key] = value _globals[key] = value
@@ -92,7 +92,12 @@ func set_global(key: String, value, ignore_reserved: bool = false) -> void:
"Global key %s is reserved and can not be overridden" % key "Global key %s is reserved and can not be overridden" % key
] ]
) )
emit_signal("global_changed", key, _globals[key], value) emit_signal(
"global_changed",
key,
_globals[key] if _globals.has(key) else null,
value
)
_globals[key] = value _globals[key] = value