Update claritas integration to support large result sets.

The output is now pulled from a json file.
This commit is contained in:
Daniel Scalzi
2020-07-18 00:41:46 -04:00
parent 0ac31e5eb7
commit 0e83a071d7
6 changed files with 43 additions and 14 deletions

View File

@@ -1,20 +1,36 @@
import { JarExecutor } from './JarExecutor'
import { join } from 'path'
import { join, resolve } from 'path'
import { ClaritasResult } from '../../model/claritas/ClaritasResult'
import { MinecraftVersion } from '../MinecraftVersion'
import { LibraryType } from '../../model/claritas/ClaritasLibraryType'
import { pathExists, remove, readFile } from 'fs-extra'
export class ClaritasWrapper extends JarExecutor<ClaritasResult> {
constructor() {
private readonly WORK_DIR: string
private readonly OUTPUT_FILE: string
constructor(cwd: string) {
super('Claritas')
this.stdoutListeners.push((data) => {
const clean = data.toString('utf8').trim() as string
const spike = 'results::'
if(clean.startsWith(spike)) {
this.lastExecutionResult = JSON.parse(clean.substr(spike.length)) as ClaritasResult
this.WORK_DIR = resolve(cwd, 'claritasWork')
this.OUTPUT_FILE = resolve(this.WORK_DIR, 'claritasOutput.json')
this.onCloseListeners.push(async (code) => {
if(code !== 0) {
this.logger.error('Claritas finished with non-zero exit code, ', code)
this.lastExecutionResult = undefined!
} else {
if(pathExists(this.OUTPUT_FILE)) {
this.lastExecutionResult = JSON.parse((await readFile(this.OUTPUT_FILE)).toString('utf8'))
} else {
this.logger.error('Claritas output file not found when exit code is 0, is this a bug?')
this.lastExecutionResult = undefined!
}
}
await this.cleanOutput()
})
}
protected getJarPath(): string {
@@ -25,8 +41,16 @@ export class ClaritasWrapper extends JarExecutor<ClaritasResult> {
return super.executeJar(
'--absoluteJarPaths', absoluteJarPaths.join(','),
'--libraryType', libraryType,
'--mcVersion', mcVersion.toString()
'--mcVersion', mcVersion.toString(),
'--outputFile', this.OUTPUT_FILE,
'--previewOutput', 'true'
)
}
private async cleanOutput(): Promise<void> {
if(pathExists(this.WORK_DIR)) {
remove(this.WORK_DIR)
}
}
}

View File

@@ -11,6 +11,7 @@ export abstract class JarExecutor<T> {
protected stdoutListeners: ((chunk: any) => void)[] = []
// eslint-disable-next-line @typescript-eslint/no-explicit-any
protected stderrListeners: ((chunk: any) => void)[] = []
protected onCloseListeners: ((code: number) => Promise<void>)[] = []
protected lastExecutionResult!: T
@@ -34,10 +35,14 @@ export abstract class JarExecutor<T> {
child.stderr.on('data', (data) => this.logger.error(data.toString('utf8').trim()))
this.stderrListeners.forEach(l => child.stderr.on('data', l))
child.on('close', code => {
child.on('close', async code => {
this.logger.info('Exited with code', code)
for(const l of this.onCloseListeners) {
await l(code)
}
resolve(this.lastExecutionResult)
})
child.on('error', (err) => {
this.logger.info('Error during process execution', err)
reject(err)