Files
collective-lists/apps/web/tests/e2e/items.test.ts
Oier Bravo Urtasun 5a63e5fc4a feat(dev): expose full auth stack on LAN IP for on-device preview
The dev stack previously mixed two hostnames (`localhost` in some places,
`keycloak` in others). That only worked because the laptop's /etc/hosts
maps `keycloak` to 127.0.0.1. Phones, tablets, or a second laptop had no
such mapping, so the OAuth flow broke the moment you tried to log in from
any non-laptop device.

Switched the SPA, Kong, GoTrue, and Keycloak client to all agree on a
single external host — the laptop's LAN IP (192.168.1.167) — so the full
Keycloak → GoTrue → Supabase → SvelteKit round-trip works from any device
on the same Wi-Fi.

Changes
  .env (root, ungitignored): PUBLIC_SUPABASE_URL / PUBLIC_KEYCLOAK_URL /
    PUBLIC_APP_URL now use the LAN IP (updated locally; tracked via
    apps/web/.env.development below).
  apps/web/.env.development: mirror the LAN IP so `$env/static/public`
    resolves the same on laptop and phone.
  apps/web/vite.config.ts: `server.host: true` — bind Vite to 0.0.0.0.
  apps/web/playwright.config.ts: `baseURL: PUBLIC_APP_URL ?? localhost`
    so E2E uses the same origin the stack is configured with.
  apps/web/tests/fixtures/login.ts:
    - wait for the collective button in the sidebar to render before
      returning (LAN-IP latency surfaced a pre-existing race in
      `handleCreate` where Enter fired before `$currentCollective`
      hydrated, silently no-op'ing).
    - derive expected app origin from PUBLIC_APP_URL.
  apps/web/tests/e2e/items.test.ts: scope D-04 delete assertion to the
    `[role="listitem"]` locator — with undoQueue enabled the toast text
    "Deleted <name>" also matches `getByText(itemName)` and shadowed the
    original check.
  infra/docker-compose.dev.yml:
    - GOTRUE_EXTERNAL_KEYCLOAK_URL and REDIRECT_URI now read from
      PUBLIC_KEYCLOAK_URL / PUBLIC_SUPABASE_URL so they follow the same
      host as the rest of the stack.
    - NEW: GOTRUE_URI_ALLOW_LIST with `/auth/callback` on both the LAN
      IP and localhost. Without an explicit allow-list GoTrue rejected
      `redirect_to=.../auth/callback` and fell back to SITE_URL root,
      stranding `?code=` at `/` and re-triggering signIn → infinite loop.
  keycloak/realm-export.json: `colectivo-web` client gains LAN-IP
    redirectUris and webOrigins (alongside the existing localhost
    entries). Persisted + live-applied via admin API.
  .gitignore: add .claude/ (per-project scheduler runtime state).

Verification
  just test-all → 224 passed, 4 skipped:
    34 pgTAP
    140 Vitest integration + 2 skipped (Realtime presence, upstream bug)
    11 Vitest unit
    39 Playwright + 2 skipped (mobile-swipe touch, WebKit-only)
  Phone sanity check: open http://192.168.1.167:5173 on a LAN device,
  log in as a seed user, full RLS-respecting session.

Caveats
  LAN IP (192.168.1.167) is DHCP-assigned — if it rotates, rerun the
  Keycloak admin API update (realm-export.json needs a new entry) and
  update the three PUBLIC_* URLs. Consider a Tailscale magic-DNS name
  as a stable replacement for the prod-deploy sprint.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2026-04-13 16:09:32 +02:00

147 lines
6.0 KiB
TypeScript

/**
* D-series (UI): Shopping item CRUD flows on `/lists/[id]`.
*
* Each test does a full Keycloak login. The seed list ("Weekly shop",
* id bbbb...) is created by supabase/seed.sql and reused read-only by all
* assertions that don't mutate it. Tests that do mutate (add / check / delete)
* use items whose names include the Date.now() stamp so they're unique.
*/
import { test, expect, type Page } from '@playwright/test';
import { USERS } from '../fixtures/users.js';
import { loginAs } from '../fixtures/login.js';
const SEED_LIST_ID = 'bbbbbbbb-bbbb-bbbb-bbbb-bbbbbbbbbbbb';
const SEED_LIST_PATH = `/lists/${SEED_LIST_ID}`;
const ADD_ITEM_PLACEHOLDER = /add item|añadir producto/i;
async function gotoSeedList(page: Page) {
await page.goto(SEED_LIST_PATH);
// Sidebar collective loaded = we're authenticated and the page has hydrated.
await expect(page.getByRole('button', { name: /Casa García-López/ })).toBeVisible({
timeout: 15_000
});
}
/** Find the row for a given item. The template sets role="listitem" per row. */
function itemRow(page: Page, name: string) {
return page.locator('[role="listitem"]').filter({ hasText: name }).first();
}
test.describe('Shopping items — member (Borja)', () => {
test.beforeEach(async ({ page }) => {
await loginAs(page, USERS.borja);
});
test('D-01: can open the seed list and see its items', async ({ page }) => {
await gotoSeedList(page);
// Seed items: Milk, Bread, Eggs, Coffee, Apples. Scope to listitem rows
// so we don't collide with the suggestion chips that share the same text.
await expect(itemRow(page, 'Milk')).toBeVisible({ timeout: 10_000 });
await expect(itemRow(page, 'Bread')).toBeVisible();
await expect(itemRow(page, 'Coffee')).toBeVisible();
});
test('D-02: can add a new item via the sticky form', async ({ page }) => {
await gotoSeedList(page);
const nameInput = page.getByPlaceholder(ADD_ITEM_PLACEHOLDER);
await expect(nameInput).toBeVisible({ timeout: 10_000 });
const itemName = `E2E-item-${Date.now()}`;
await nameInput.fill(itemName);
await nameInput.press('Enter');
await expect(page.getByText(itemName)).toBeVisible({ timeout: 5_000 });
// Reload to confirm the item persisted (not just optimistic).
await page.reload();
await expect(page.getByText(itemName)).toBeVisible({ timeout: 10_000 });
});
test('D-03: can check an item — toggles the aria-checked state', async ({ page }) => {
await gotoSeedList(page);
// Add a fresh item so we don't race with other tests' check state.
const nameInput = page.getByPlaceholder(ADD_ITEM_PLACEHOLDER);
await expect(nameInput).toBeVisible({ timeout: 10_000 });
const itemName = `Check-me-${Date.now()}`;
await nameInput.fill(itemName);
await nameInput.press('Enter');
await expect(page.getByText(itemName)).toBeVisible({ timeout: 5_000 });
const row = itemRow(page, itemName);
const toggle = row.getByRole('button', { name: /toggle item|uncheck item/i });
await toggle.click();
// A checked item is moved into the "Checked" section. Verify it still
// shows on the page (it slides to the checked list with animation).
await expect(page.getByText(itemName)).toBeVisible({ timeout: 5_000 });
});
test('D-04: can delete an item on desktop via the trash button', async ({ page }) => {
await gotoSeedList(page);
const nameInput = page.getByPlaceholder(ADD_ITEM_PLACEHOLDER);
await expect(nameInput).toBeVisible({ timeout: 10_000 });
const itemName = `Delete-me-${Date.now()}`;
await nameInput.fill(itemName);
await nameInput.press('Enter');
await expect(itemRow(page, itemName)).toBeVisible({ timeout: 5_000 });
const row = itemRow(page, itemName);
await row.hover();
// The row has 3 "Delete" buttons in markup (swipe-reveal behind the row,
// desktop-hover on the row, and a checked-state one). The desktop-hover
// button is the one with `sm:flex` — target it via class.
await row.locator('button.sm\\:flex[aria-label="Delete"]').click();
// After Fase 5.5 the delete goes through the undo queue: the row is
// removed immediately, but a toast briefly shows "Deleted <name>" — that
// substring matches `getByText(itemName)`. Scope the assertion to the
// item list (role="listitem") so the toast is ignored.
await expect(itemRow(page, itemName)).not.toBeVisible({ timeout: 5_000 });
});
test('D-06: frequency suggestions render below the add-item input', async ({ page }) => {
await gotoSeedList(page);
const nameInput = page.getByPlaceholder(ADD_ITEM_PLACEHOLDER);
await expect(nameInput).toBeVisible({ timeout: 10_000 });
// Focus the input. The seed data has "milk", "bread", "eggs", etc. in
// item_frequency, so suggestion chips should render.
await nameInput.click();
// At least one of the seed-frequency items should be visible as a chip.
await expect(page.getByRole('button', { name: /^milk$/i })).toBeVisible({ timeout: 5_000 });
// Typing a prefix should narrow suggestions. "mi" matches "milk".
await nameInput.fill('mi');
await expect(page.getByRole('button', { name: /^milk$/i })).toBeVisible({ timeout: 3_000 });
});
});
test.describe('Shopping items — guest (David, read-only)', () => {
test.beforeEach(async ({ page }) => {
await loginAs(page, USERS.david);
});
test('D-10: David sees seed items but cannot commit a new one', async ({ page }) => {
await gotoSeedList(page);
await expect(itemRow(page, 'Milk')).toBeVisible({ timeout: 15_000 });
// Either the add input is hidden for guests, or typing + Enter does not
// commit a persisted item (RLS blocks the insert → the optimistic row,
// if any, rolls back).
const input = page.getByPlaceholder(ADD_ITEM_PLACEHOLDER);
const visible = await input.isVisible({ timeout: 2_000 }).catch(() => false);
if (visible) {
const name = `Guest-sneaky-${Date.now()}`;
await input.fill(name);
await input.press('Enter');
await page.waitForTimeout(1_500);
await page.reload();
// After reload, nothing persisted on the server should render.
await expect(page.getByText(name)).not.toBeVisible({ timeout: 5_000 });
}
});
});