oier/gymkhana-actions
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

fix: eliminate escoria/esc/command_paths that duplicates escoria/main/command_directories

Browse Source 
It appears that the settings `escoria/esc/command_paths` and
`escoria/main/command_directories` have duplicate purposes.
Unfortunately, they are read in different places, so if you add a
directory to one setting, it will not be present in the other.
Specifically, `ESCCompiler` read from `escoria/esc/command_paths`
while `ESCCommand` and `ESCCommandRegistry` read from
`escoria/main/command_directories`.

As the `COMMAND_PATHS` constant had no references, it seemed more
appropriate to delete.

The `escoria/esc/command_paths` appears to have been set initially in
`project.godot` as part of:

https://github.com/godot-escoria/escoria-demo-game/pull/467
This commit is contained in:
Michael Bolin
2022-03-20 20:35:03 -07:00
committed by Julian Murgia
parent 23b51938e7
commit a3c8fe882e
3 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
project.godot
View File

@@ -761,7 +761,6 @@ debug/crash_message="We're sorry, but the game crashed. Please send us the follo
%s"
ui/default_dialog_scene="res://addons/escoria-core/ui_library/dialogs/floating_dialog_player.tscn"
esc/command_paths=[ "res://addons/escoria-core/game/core-scripts/esc/commands" ]
main/game_migration_path=""
[input]