oier/gymkhana-actions
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix: makes dialog players pausable by removing yields (#472)

Browse Source
This commit is contained in:
Julian Murgia
2021-12-01 09:39:24 +01:00
committed by GitHub
parent ff00a97679
commit b4d5e380e6
11 changed files with 100 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
addons/escoria-dialog-simple/esc_dialog_simple.gd
View File

@@ -49,9 +49,18 @@ func say(dialog_player: Node, global_id: String, text: String, type: String):
_type_player = preload(\
"res://addons/escoria-dialog-simple/types/avatar.tscn"\
).instance()
_type_player.connect("say_finished", self, "_on_say_finished", [], CONNECT_ONESHOT)
_dialog_player.add_child(_type_player)
_type_player.say(global_id, text)
yield(_type_player, "say_finished")
# yield(_type_player, "say_finished")
# if _dialog_player.get_children().has(_type_player):
# _dialog_player.remove_child(_type_player)
# emit_signal("say_finished")
func _on_say_finished():
if _dialog_player.get_children().has(_type_player):
_dialog_player.remove_child(_type_player)
emit_signal("say_finished")
@@ -86,3 +95,10 @@ func interrupt():
if _dialog_player.get_children().has(_type_player):
_dialog_player.remove_child(_type_player)
emit_signal("say_finished")
# Getter for the type player
#
# *Returns* the type player
func get_type_player() -> Node:
return _type_player